CB-231: Use direct database access for entity: place #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered using mbdata package for this purpose? |
ferbncode
force-pushed
the
cb-231-entity/plate
branch
11 times, most recently
from
6f870b7
to
d6dca2d
Compare
ferbncode
changed the title
gentlecat
suggested changes
Jun 26, 2017
| @@ -0,0 +1,16 @@ | |||
| import critiquebrainz.frontend.external.musicbrainz_db.exceptions as mb_exceptions | |||
|
|
|||
| RELATABLE_TYPES = ['area', 'artist', 'label', 'place', 'event', 'recording', 'release', 'release-group', 'series', 'url', 'work', 'instrument'] | |||
There was a problem hiding this comment.
This row is a bit too long. Can you split it like this?
RELATABLE_TYPES = [
'area',
...
'instrument',
]
gentlecat
reviewed
Jun 26, 2017
| THREAD_POOL_PROCESSES = 10 | ||
|
|
||
|
|
||
| def get_place_by_id(id): |
There was a problem hiding this comment.
It's better to be more specific here and use mbid instead of id. I usually try to avoid using id since it's a built in function.
|
Haven't been able to test this due to problems with the MusicBrainz database image setup. https://chatlogs.metabrainz.org/brainzbot/metabrainz/2017-06-26/?msg=3940782&page=2 |
ferbncode
force-pushed
the
cb-231-entity/plate
branch
2 times, most recently
from
9c5c988
to
e49ce44
Compare
ferbncode
force-pushed
the
cb-231-entity/plate
branch
from
e49ce44
to
500bddb
Compare
gentlecat
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use direct database access for entity
place. I have added functionsentity_relation_helperandget_place_by_idfor fetching information regardingplace.